Code refacto

[andrelec1]

sellsy-client/src/Core/Request.php

Line 154 in 2cd0185

public function __call($method, $args)

This look like bad code for me...
But this is not the first time i see this in random php project.

So some one can explain why using this pattern ?

[tgeorgel]

Are you talking about the __call() magic method or the inner switch statement ?

[andrelec1]

I talk about the inner switch ....

The switch case statement is here to avoid the poor perf of call_user_func_array ...
But all this code can be replaced by this single line :
$this->req = $this->req->$method(...$args);

( Argument Unpacking have been implemented in php 5.6 ... lib require php 7.4 so... why not using it ? )

[tgeorgel]

Well it is just a matter of habit, unpacking is indeed a nicest way to do so :)