Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect unit and interpretation when calculating average and other statistics #86

Open
jamaa opened this issue Nov 9, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jamaa
Copy link
Member

jamaa commented Nov 9, 2022

Currently, the Timeseries.Average property returns the simple arithmetic mean of all values. For non-equidistant timeseries, this value can be misleading. Simlarly, analysis function such as MonthlyStatistics and AnnualStatistics output statistical values that do not respect the unit and interpretation of time series either, potentially causing wrong or at least misleading results.

The unit and interpretation needs to be respected everywhere.

For this, Wave needs to be able to understand units and then calculate proper, volume-based averages.

For statistics based on a time period such as month or year, the time series is probably best first converted to monthly/annual values using the ChangeTimestep method. This method also needs to be able to understand units.

For unknown units, Wave should probably just not output statistics at all and/or ouput an error message.

@jamaa jamaa added the enhancement New feature or request label Nov 9, 2022
@jamaa jamaa self-assigned this Nov 9, 2022
@jamaa
Copy link
Member Author

jamaa commented Nov 12, 2022

@jamaa
Copy link
Member Author

jamaa commented Nov 12, 2022

@jamaa
Copy link
Member Author

jamaa commented Sep 12, 2023

Since #112 was fixed, volume calculation accurately considers interpretation and gaps. We could use similar logic for calculating more accurate averages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant