-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpretation of WEL files #113
Comments
The current implementation of how WEL series are interpreted actually corresponds to how Talsim calculates/outputs its results. All results are the average for the timestep, except for volume, which is instantaneous for the timestamp (don't ask me why). Are you sure BlueM.Sim is different? |
Actually it does seem to be different for BlueM.Sim:
https://wiki.bluemodel.org/index.php/WEL-Format_(BlueM) Unfortunately the information in the wiki is incomplete. Do you know more? We would have to figure out a way to distinguish BlueM WEL files from Talsim WEL files in order to implement this though.
Unfortunately interpretation is often neglected when storing time series (and also in model documentation!), most file formats do not even support specifying it. But whatever we can find out should also be added to Wave. Let me know if you have any info. For example, I have seen BlueM.Wave/source/FileFormats/UVF.vb Lines 143 to 146 in 037010d
Because of this and other issues with file formats, I have sometimes even thought about defining a new time series file format, but you know how it is with standards :-) https://xkcd.com/927/ |
To get back to the original question:
|
Since Wave version 1.6.2 (commit 4d4712e) nearly all time series in WEL-files are interpreted as block right (except title includes "_VOL"):
BlueM.Wave/source/FileFormats/WEL.vb
Lines 207 to 212 in 037010d
Why is there a differation between volume curves (from BlueM.Sim) and everything else?
Could it be an enhencement to catch up multiple curve types from BlueM.Sim (and maybe other simulation models) and map it to the diffrent interpretation types?
Such as:
(Maybe uncomplete)
The text was updated successfully, but these errors were encountered: