Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible rounding errors in EFL file #9

Open
jamaa opened this issue Jun 25, 2022 · 1 comment
Open

Possible rounding errors in EFL file #9

jamaa opened this issue Jun 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jamaa
Copy link
Member

jamaa commented Jun 25, 2022

as discussed in #8 it is theoretically possible that the values for the column "Flaeche" written to the EFL file for one EZG do not add up to 100% anymore after rounding (tolerance in BlueM.Sim is currently 0.001%).

If this turns out to be a real problem and we wanted to avoid it, the plugin would either have to adjust values accordingly after rounding or the tolerance in BlueM.Sim needs to be changed (unsure what consequences this would have, though).

@jamaa jamaa added the enhancement New feature or request label Jun 25, 2022
@MartinGrosshaus
Copy link
Collaborator

I was working under the assumption that the tolerance was 0.001 (= 0.1%).
%.... classic source for math confusion :D
With the tolerance being 0.001% this could really be a problem.

Due to the way the plugin handles every value separatly, it would be difficult to handle the correction for a possible sum deviation while checking the values.
I think the easiest way to solve that potential problem (without caches etc.) would be to read in the (rounded) data after all values were handled and check it then for every mentioned EZG.

Do you know about similar tolerance-issues with other file types?
Then we can solve them all with one general function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants