Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default workers to 20? #154

Closed
Rafnuss opened this issue Jan 5, 2025 · 2 comments
Closed

Default workers to 20? #154

Rafnuss opened this issue Jan 5, 2025 · 2 comments

Comments

@Rafnuss
Copy link
Contributor

Rafnuss commented Jan 5, 2025

workers = 2,

Is there a reason for the default number to not be

workers = min(length(request_list, 20))

And should we add a warning if this number exceeds 20? Not sure what happen in this case.

@khufkens
Copy link
Member

khufkens commented Jan 13, 2025

The reason for this is that although historically the theoretical limit was ~20 requests (old API, can't find the link to the docs), in practice this is often lower. The value is now set at 2 to make this a conscious decision by the user, rather than trigger a default greedy, take whatever we can get, position.

I should look at the code but if things get rejected there will be a retry, I think.

@khufkens
Copy link
Member

Yep, the queue is N long and refilled based on another queue - the requests list. See while loop.

while (length(done) < length(request_list) & Sys.time() < timeout_time) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants