Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation not correctly imported #84

Open
st142148 opened this issue Jul 25, 2022 · 3 comments
Open

German translation not correctly imported #84

st142148 opened this issue Jul 25, 2022 · 3 comments

Comments

@st142148
Copy link

Hi,
I'm quite happy the german translation was added, thank you for that.
But there are a lot of errors. None of them bad translations, but rather just the wrong words being translated, i.e. 三つ = mawashi (the sumo garment). Also single kanji words like 品 (しな, ひん) getting mixed up.

Before I go about checking all 2200 kanji + ~9000 words, is there a way to correct this at import?
Also am I correct in thinking the dictionary is just a sqlite database gzipped?

@st142148 st142148 changed the title How was the german translation imported? German translation not correctly imported Jul 25, 2022
@blastrock
Copy link
Owner

They do seem to be mixed up indeed.

The sqlite database is a compilation I made from various sources (see About in the app). The German word translations come from JMdict, but since words usually have multiple definitions, I take the first one, hoping that it's the most common.

In the case of 三つ, it is not:

<gloss xml:lang="ger">Mawashi (Lendentuch der Sumōringer)</gloss>
<gloss xml:lang="ger">drei</gloss>
<gloss xml:lang="ger">drei</gloss>
<gloss xml:lang="ger">drei Stück</gloss>
<gloss xml:lang="ger">drei Jahre alt</gloss>

Unfortunately, I have no way of ordering these entries automatically. I don't really know what to do for this.

@st142148
Copy link
Author

How/what are you querying?
Using WWWJDIC seems to get the first result right, though I don't know how they are ranking the results.
Also should it not be possible to only get exact matches? (And then look at the reading)

@blastrock
Copy link
Owner

The snippet from my previous post comes from the JMdict XML file.

You link doesn't work for me, I think you can't link WWWJDIC. I tried searching it myself, and i noticed it says that the German dictionary comes from WaDoku, so I searched there too and Mawashi is the first definition, even though WWWJDIC gets it right.

I don't really know how WWWJDIC uses WaDoku, and how JMdict integrates it. I believe the issue should be fixed with JMdict instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants