Icon Compact Layout Type - Doesn't Fit Well On A Vertical Panel Width

[jotapesse]

Hi! I previously used the Weather Widget 1. Moved to Weather Widget 2 as the first no longer works well on Plasma 5.26. I'm using a vertical panel in floating mode. The Weather Widget icon on the panel can get too wide for the panel width. The temperature always goes off to the right edge of the panel. In comparison the first widget still works better. It seems that the Icon size and the temperature text is not properly placed. In the following screenshots I have purposely placed both widgets (1 and 2) from top to bottom. The bottom one is of course Weather Widget 2. Can you please fix this issue?

Operating System: Debian GNU/Linux Sid
KDE Plasma Version: 5.26.0
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Weather Widget 2 v2.3.4 in Compact Layout Type

Even if defloating the panel and depending on the weather icon in use, temperature always gets too much to the right edge of the panel, not as centered as the first widget:

[blackadderkate]

I think I have a fix for this (see below).

It seems to work on my login, but it needs thoroughly testing using different themes & distributions before I can release it.

Diff attached if you want to give it a try, and know how to apply it...
patch.txt

[jotapesse]

Hi! Thanks. That indeed seems to fix it for the temperature text. Still noticable missing fixes are for the following. Hopefully you can fix them as well? I'm using the default Plasma Breeze Dark theme by the way.

• Weather icon: depending on icon it can get over the right edge of the panel;
• Last Updated time text: string font size does not adjust and it gets over the right panel edge.

[jotapesse]

Looking briefly at the code I would say that the widget window/box size (witdh x height) doesn't compute well in the Compact Layout, at least not as well as the Weather Widget 1. I wish I knew more of QML Qt Quick code so that I could help more. Hopefully this will help you pin point it?

[blackadderkate]

Apologies if this is a bit garbled - it's 1am and I need sleep!

I think I've got a version that works - give this beta version a try

Update using plasmapkg -u

You can Increase/Decrease the font size in the Config/Appearance section to tweak them to your liking.

[jotapesse]

Hi! I appreciate your effort. Still doesn't seem to work that well. The widget icon is equally affected by the font size change. The last updated text still gets over the panel edge in any case. Perhaps you could bring back the code from the Weather Widget 1 on how the widget/font sizes are computed?

First screenshot with the default 32px font size. Second screenshot is with a font size of 20px to equal the Weather Widget 1 temperature font size.

[blackadderkate]

Unfortunately the WeatherWidget1 code has several issues. I had complaints that "single digit" temperatures (e.g. 7°C) had "unacceptable" gaps, whilst "triple digit" temperatures (e.g. 100°F) would clip or overlap the icon . I also had several requests to make the fonts and font-size customisable.
And there were even more issues if a user had customised their theme font, DPI or Screen Scaling settings.

So I was pretty-much forced to rewrite it, but I'm not going to give up trying to get it 100% perfect...

[blackadderkate]

OK, try this version
It's basically the old layout from v1, but with a few tweaks.

[blackadderkate]

I have just uploaded a fix for this issue.

Please try downloading and installing this new beta version.

[jotapesse]

Much better! Great job! Thank you! Now to make it perfect and it is a really minor detail, if you could apply to the temperature text font the same kind of character outline effect. I'm using the "Default" font. If you look closely at both widgets you'll notice that the weather widget 1 text seems to standout more (improving its readability against the icon background). Really minor but would make it perfect I guess. :-)

[jotapesse]

[jotapesse]

Hi again. Another noticeable glitch is when the last updated time reaches a time of double digits. The text line no longer gets over the edge but now it wraps to a second line below. It would be best if it would be kept on the same single line, downsizing the font or having the font size calculated to accomodate double digits in the first place. Similar to what Weather Widget 1 does I guess? Sorry to be a pain...

[thelaughinggnome]

Might be of interest: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/268