Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test improvement - don't duplicate #5

Open
viktorbenei opened this issue Sep 27, 2016 · 0 comments
Open

Unit test improvement - don't duplicate #5

viktorbenei opened this issue Sep 27, 2016 · 0 comments
Assignees
@godrei

Comments

@viktorbenei
Copy link
Contributor

Don't duplicate the same array: https://github.com/bitrise-tools/go-xamarin/blob/master/solution/solution_test.go#L263

desiredConfigs and desiredMappedConfigs are the same

instead of these we should rather compare solution.ConfigMap to a value, to make sure that it's the same, and not just the specified values are the same!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@godrei godrei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viktorbenei @godrei