From 9bebccf47ea9e4e7d3b0578c39aae5280d778152 Mon Sep 17 00:00:00 2001 From: Malte Rohde Date: Thu, 25 Jul 2024 09:53:48 +0200 Subject: [PATCH] Remove Alpine 3.16 from test matrix (#315) This removes our Alpine 3.16-based test image as it was heavily flaky (failing with timeouts in about every other test run) and we have no idea how to fix it. On the other hand, we have run ChromicPDF on Alpine 3.16 for years and it worked perfectly fine. Additionally, the situation seems to have improved with more recent Chromiums a lot, so that the other test images do not have timeout issues anymore. Alpine 3.16 is also quite old by now, so I conclude we're ok to just drop it, in favor of having green test runs again some day. --- .github/docker/Dockerfile_alpine-3-16-2 | 40 ------------------------- .github/workflows/publish-image.yml | 2 +- .github/workflows/test.yaml | 2 +- README.md | 1 - 4 files changed, 2 insertions(+), 43 deletions(-) delete mode 100644 .github/docker/Dockerfile_alpine-3-16-2 diff --git a/.github/docker/Dockerfile_alpine-3-16-2 b/.github/docker/Dockerfile_alpine-3-16-2 deleted file mode 100644 index c6c1735..0000000 --- a/.github/docker/Dockerfile_alpine-3-16-2 +++ /dev/null @@ -1,40 +0,0 @@ -FROM hexpm/elixir:1.14.0-erlang-25.1-alpine-3.16.2 - -USER root - -RUN apk update \ - && apk add --no-cache \ - chromium \ - # Will install ghostscript 9.56 - ghostscript \ - # # for verapdf & ZUV - openjdk11-jre \ - # for pdftotext & friends - poppler-utils \ - # for identifying images - imagemagick \ - # for 'kill' - procps \ - # temporary for installation below - wget \ - unzip \ - # GNU tar needed by actions/cache - tar - -RUN mkdir /opt/verapdf -WORKDIR /opt/verapdf -RUN wget http://downloads.verapdf.org/rel/verapdf-installer.zip \ - && unzip verapdf-installer.zip \ - && mv verapdf-greenfield* verapdf-greenfield \ - && chmod +x verapdf-greenfield/verapdf-install -COPY .github/docker/auto-install.xml /opt/verapdf/verapdf-greenfield -RUN ./verapdf-greenfield/verapdf-install auto-install.xml - -WORKDIR /opt/zuv -RUN wget https://github.com/ZUGFeRD/ZUV/releases/download/v0.8.3/ZUV-0.8.3.jar -ENV ZUV_JAR /opt/zuv/ZUV-0.8.3.jar - -RUN apk del \ - wget \ - unzip \ - && rm -rf /var/lib/apt/lists/* diff --git a/.github/workflows/publish-image.yml b/.github/workflows/publish-image.yml index 1b28969..3f9c00b 100644 --- a/.github/workflows/publish-image.yml +++ b/.github/workflows/publish-image.yml @@ -31,7 +31,7 @@ jobs: packages: write strategy: matrix: - dockerfile: ['elixir-1-11', 'debian-buster', 'alpine-3-16-2', 'alpine-3-17-3', 'alpine-3-18-4'] + dockerfile: ['elixir-1-11', 'debian-buster', 'alpine-3-17-3', 'alpine-3-18-4'] steps: - name: Checkout repository diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 1b7a1ab..4a88012 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -5,7 +5,7 @@ jobs: name: ${{ matrix.tag }} strategy: matrix: - tag: ['elixir-1-11', 'debian-buster', 'alpine-3-16-2', 'alpine-3-17-3', 'alpine-3-18-4'] + tag: ['elixir-1-11', 'debian-buster', 'alpine-3-17-3', 'alpine-3-18-4'] env: MIX_ENV: test runs-on: ubuntu-latest diff --git a/README.md b/README.md index 80b34ea..ec69cc7 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,6 @@ ChromicPDF is tested in the following configurations: | ------ | ---------- | --------------- | --------------- | ----------- | | 1.15.7 | 26.2 | Alpine 3.18 | 119.0.6045.159 | 10.02.0 | | 1.14.5 | 25.3.1 | Alpine 3.17 | 112.0.5615.165 | 10.01.1 | -| 1.14.0 | 25.1 | Alpine 3.16 | 102.0.5005.182 | 9.56.1 | | 1.14.0 | 25.1 | Debian Buster | 90.0.4430.212-1 | 9.27 | | 1.11.4 | 22.3.4.26 | Debian Buster | 90.0.4430.212-1 | 9.27 |