Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bb_targets and mask_targets may be unbound #121

Open
Ertz012 opened this issue Feb 1, 2024 · 2 comments
Open

bb_targets and mask_targets may be unbound #121

Ertz012 opened this issue Feb 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Ertz012
Copy link

Ertz012 commented Feb 1, 2024

https://github.com/bit-bots/YOEO/blob/0aaecc2359c619db8f8666b0f3890044308578ba/yoeo/utils/datasets.py#L143C9-L143C55

@Ertz012 Ertz012 added the bug Something isn't working label Feb 1, 2024
@Ertz012 Ertz012 added this to Software Feb 1, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Software Feb 1, 2024
@Ertz012 Ertz012 moved this from 🆕 New to 🔖 Ready in Software Feb 1, 2024
@jaagut
Copy link
Member

jaagut commented Feb 1, 2024

On the way I thought about it, and I think making transforms optional is just not necessary. I believe in almost all cases one wants to apply some transforms, at least the default ones. If transforms is not necessary, we leave out the if check and the variables cannot be unbound anymore

@Flova
Copy link
Member

Flova commented Feb 1, 2024

I am not sure what the exact problem is? Could you provide additional information? Is it related to batching/transforms when a batch consists only of negative data?

@texhnolyze texhnolyze moved this from 🔖 Ready to 📋 Backlog in Software Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants