Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests to work with the new setup #57

Open
JesperBrink opened this issue May 16, 2019 · 0 comments
Open

Update unit tests to work with the new setup #57

JesperBrink opened this issue May 16, 2019 · 0 comments
Labels
bug Something isn't working Testing This topic is regarding testing the software

Comments

@JesperBrink
Copy link
Collaborator

We have changed a lot of the way that we work with the code, but we havn't updated our unit tests to match that. When running our unit tests the following tests fails:

======================================================================
ERROR: test_add_requirement (test.test_recipe.TestRecipeClass)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jesperbrink/Desktop/work/bioconda_recipe_gen/test/test_recipe.py", line 64, in test_add_requirement
    recipe = Recipe("test/files_for_testing/kallisto_recipe_with_hdf5.txt")
TypeError: __init__() missing 1 required positional argument: 'version'

======================================================================
ERROR: test_initialization_method (test.test_recipe.TestRecipeClass)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jesperbrink/Desktop/work/bioconda_recipe_gen/test/test_recipe.py", line 35, in test_initialization_method
    recipe = Recipe("test/files_for_testing/full_kallisto_recipe.yaml")
TypeError: __init__() missing 1 required positional argument: 'version'

======================================================================
ERROR: test_write_recipe_to_meta_file (test.test_recipe.TestRecipeClass)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jesperbrink/Desktop/work/bioconda_recipe_gen/test/test_recipe.py", line 46, in test_write_recipe_to_meta_file
    recipe = Recipe(temp_file_path)
TypeError: __init__() missing 1 required positional argument: 'version'

======================================================================
ERROR: test_exit_codes_is_success_for_kallisto (test.test_build.TestMiniIterativeBuild)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jesperbrink/Desktop/work/bioconda_recipe_gen/test/test_build.py", line 40, in test_exit_codes_is_success_for_kallisto
    proc = build.mini_iterative_build()
TypeError: mini_iterative_build() missing 1 required positional argument: 'recipe'

----------------------------------------------------------------------

It could be nice to have these tests updated, such that the unit tests doesn't crash because of incorrect use of functions.

@JesperBrink JesperBrink added bug Something isn't working Testing This topic is regarding testing the software labels May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Testing This topic is regarding testing the software
Projects
None yet
Development

No branches or pull requests

1 participant