Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with a new PubSubClient library #11

Open
anarro opened this issue Jun 4, 2016 · 7 comments
Open

Update with a new PubSubClient library #11

anarro opened this issue Jun 4, 2016 · 7 comments

Comments

@anarro
Copy link

anarro commented Jun 4, 2016

Hi,

Please, can you update your code with a new library version of PubSubClient?, I try use your library (in another issue) but I didn't get it. please!

Antoni.

@biohazardxxx
Copy link
Owner

Hi, I will when I am at home again in two weeks.
Br
Am 05.06.2016 00:28 schrieb "Antoni" [email protected]:

Hi,

Please, can you update your code with a new library version of
PubSubClient?, I try use your library (in another issue) but I didn't get
it. please!

Antoni.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11, or mute the
thread
https://github.com/notifications/unsubscribe/ABTo-uj3U8LrgHWVdJ0qiY8dUbNYyQNrks5qIe3ggaJpZM4IuORN
.

@anarro
Copy link
Author

anarro commented Jun 5, 2016

Thank you very match!, we are waiting for you...

Antoni.

@biohazardxxx
Copy link
Owner

Hi Antoni,
I've now updated the code to work with latest knolleary/pubsubclient and also uploaded the compiled binary file. However I did not tested it. please let me know if you have issues.

@anarro
Copy link
Author

anarro commented Jun 16, 2016

Hi biohazardxxx thank you for you time!, while i was waiting your news i tried make the changes and i've had good luck!!..., but i can't see your changes or differences in your code/library.. it's possible?

@biohazardxxx
Copy link
Owner

Ah sorry I missed to mention that I created a new branch staging since I did not test the changes yet.
https://github.com/biohazardxxx/ESP_WiFiSwitch/tree/staging

Sorry!

@biohazardxxx
Copy link
Owner

But please let me know if it works so I can merge to master.

@biohazardxxx biohazardxxx reopened this Jun 16, 2016
@anarro
Copy link
Author

anarro commented Jun 16, 2016

Hi, the changes that I proposed it's correct and work good. I can't see your code your changes in "staging"..

master-staging

I don't know very well how gihub works...sorry!!,

And I like add a username/password to access a mqtt server...(thats isn't a issues its new request... I try it in my fork.!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants