Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore adding eslint or similar for enforced code styling #23

Open
bbimber opened this issue Aug 13, 2021 · 1 comment
Open

Explore adding eslint or similar for enforced code styling #23

bbimber opened this issue Aug 13, 2021 · 1 comment
Assignees

Comments

@bbimber
Copy link
Contributor

bbimber commented Aug 13, 2021

While the lab's modules has JS going back 10+ years, the typescript/react codebase is almost brand new. It might be useful to have a build step that automatically enforces code styling. eslint is one I'm vaguely familiar with, and has some LabKey hooks:

https://github.com/LabKey/labkey-ui-components/blob/develop/packages/eslint-config-base/README.md

I'd be in favor of putting in some tighter restrictions on styling (like var/let/const), etc. Also enforcing a standard code style. Do you have experience with eslint or similar, and can you have a look at this or similar options?

@bbimber
Copy link
Contributor Author

bbimber commented Aug 13, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants