Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor email sending methods to not require HttpRequest unless necessary #1540

Open
mikkonie opened this issue Jan 10, 2025 · 0 comments
Open

Refactor email sending methods to not require HttpRequest unless necessary #1540

mikkonie opened this issue Jan 10, 2025 · 0 comments
Assignees
@mikkonie
Labels
app: projectroles Issue in the projectroles app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone
v1.2.0

Comments

@mikkonie
Copy link
Collaborator

Related to #1539. At least all methods using get_role_change_body() require a HttpRequest object for build_absolute_uri().

An alternative to build_absolute_uri() would be to use SODAR_API_DEFAULT_HOST. This of course requires the admins of SODAR Core based sites to provide correct settings on their site, but we should trust them that much ;)

There also might be other replacements for this, I'll look into it.
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: projectroles Issue in the projectroles app labels Jan 10, 2025
@mikkonie mikkonie added this to the v1.2.0 milestone Jan 10, 2025
@mikkonie mikkonie self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: projectroles Issue in the projectroles app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@mikkonie