hx-ext="sse" elements should include hx-vals attributes as query params

[bradleyjkemp]

I want to be able send some dynamic query params as part of an sse request like so:

<div hx-ext="sse" sse-connect="/events" hx-vals="js:{dynamicValue: foo()}>

But the hx-vals are not included in the eventsource connect:

htmx-extensions/src/sse/sse.js

Lines 178 to 185 in ba3d167

	// handle extension source creation attribute
	if (api.getAttributeValue(elt, 'sse-connect')) {
	var sseURL = api.getAttributeValue(elt, 'sse-connect')
	if (sseURL == null) {
	return
	}
	ensureEventSource(elt, sseURL, retryCount)

htmx-extensions/src/sse/sse.js

Lines 191 to 192 in ba3d167

	function ensureEventSource(elt, url, retryCount) {
	var source = htmx.createEventSource(url)

Only the value of sse-connect is used

[ErikEngerd]

The same issue also applies to the ws extension.

[fastpok]

I had a similar problem with WebSockets extension. Try changing single quotes to double quotes.

This did not work for me:
hx-vals="{'a': 'b'}"

But this one worked:
hx-vals="{"a": "b"}"