-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable indirection of PSK/ticket storage (ClientSessionCache) #111
Comments
@FiloSottile Can you add more detail here? Since #107, the client should send whatever https://github.com/bifurcation/mint/blob/master/handshake.go#L188 Looking at that code now, it does have some bugs, for which I filed #112. But I don't think it has the bug you're complaining about :) |
Rerunning this, I remember noticing a while ago. |
Ok, with the latest code my server does send a Ticket. However, it's never returned. This is the client func main() {
tr := &http.Transport{
DialTLS: func(network, addr string) (net.Conn, error) {
return mint.Dial(network, addr, nil)
},
DisableKeepAlives: true,
}
client := &http.Client{Transport: tr}
resp, err := client.Get("https://" + os.Args[1])
if err != nil {
log.Fatal(err)
}
if err := resp.Write(os.Stdout); err != nil {
log.Fatal(err)
}
// Resumption
resp, err = client.Get("https://" + os.Args[1])
if err != nil {
log.Fatal(err)
}
if err := resp.Write(os.Stdout); err != nil {
log.Fatal(err)
}
} and this is the trace that I'm still going through
|
I thought it might be that the default Config is not global, but this didn't fix it: c := &mint.Config{
ServerName: "example.com",
}
tr := &http.Transport{
DialTLS: func(network, addr string) (net.Conn, error) {
return mint.Dial(network, addr, c)
},
DisableKeepAlives: true,
}
client := &http.Client{Transport: tr} |
No, the problem is that PSKs in |
Looks like |
NSS is off-spec sending the ticket anyway, Tris won't.
The text was updated successfully, but these errors were encountered: