Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some "get" methods still exist after replacement by "get_attribute_value" #566

Open
thiagomarinho opened this issue Jul 5, 2019 · 0 comments
Open

Some "get" methods still exist after replacement by "get_attribute_value" #566

thiagomarinho opened this issue Jul 5, 2019 · 0 comments

Comments

@thiagomarinho
Copy link
Contributor

Hi @biemond , how are you?

This commit changes all providers located at files directory (replacing get with get_attribute_value, but I noticed that in some cases the old method (get) is being used. Should we fix that, or is it right?

Some examples:

https://github.com/biemond/biemond-orawls/blob/puppet4/files/providers/wls_jdbc_persistence_store/index.py.erb#L10

https://github.com/biemond/biemond-orawls/blob/puppet4/files/providers/wls_coherence_server/index.py.erb#L18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thiagomarinho