Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other commands #9

Open
gfcittolin opened this issue Jul 10, 2019 · 2 comments
Open

Support for other commands #9

gfcittolin opened this issue Jul 10, 2019 · 2 comments

Comments

@gfcittolin
Copy link

Hi,

first of all congratulations for your work, I was actually not expecting to find a FTP server on Node-RED! But we're planning here to use it for an application that would require the client not only to put files, but also to read them. Generally speaking, the following changes would need to be done:

  • Making the fs layer pluggable, mainly offering the current option of an in-memory file system or a path of the real fs;
  • Making the timeout to delete the file (for the in-memory option) configurable;
  • Exposing the other events to Node-RED, mainly readFile (but possibly others too)

We're interested in making a PR for all this, keeping everything as compatible as possible with how it currently works, so we don't need yet another FTP server node. Would you be interested in such contribution?

@biddster
Copy link
Owner

Super interested in this.

Initial thoughts are that we would have to preserve the existing "virtual" mode as the default and have "real" mode as an option.

But yeah, PR away!

@gfcittolin
Copy link
Author

Nice! I think we'll probably need to "split" in a configuration node and input/output nodes to support a better usage across a flow. Well, it will take some time till we start working on it (we need to finish some other projects first), but then we can discuss it a bit more in details. Great to have you open to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants