Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments on some files #71

Open
realsobek opened this issue Apr 13, 2016 · 1 comment
Open

comments on some files #71

realsobek opened this issue Apr 13, 2016 · 1 comment
Assignees

Comments

@realsobek
Copy link

the files:
admin/.htaccess.sample
admin/index.php
admin/upgrade.php
admin/upgrade/class.JtUpgrader.php
admin/upgrade/history/ver_0.4
css/media.css
doc/github/version_0.4_unreleased.md
js/foundation/foundation-select/foundation-select.css
js/vendor/jquery.quicksearch.min.js
js/vendor/jquery.serialize_checkbox.js
js/vendor/tinysort.min.js
js/vendor/waypoints.min.js
js/vendor/jquery-qrcode/example.html
js/vendor/jquery-qrcode/jquery.qrcode.min.js
js/vendor/jquery-qrcode/lib/qrcode.js
js/vendor/jquery-ui/jquery-ui.js
js/vendor/jquery-ui/jquery-ui.min.css
js/vendor/jquery-ui/jquery-ui.min.js
js/vendor/jquery-ui/jquery-ui.structure.min.css
js/vendor/jquery-ui/jquery-ui.theme.min.css
languages/de_DE/jquery.timeago.de_DE.js
languages/en_US/jquery.timeago.en_US.js
sys/bootstrap.functions.php
sys/jt-gettext.php
sys/php-gettext/gettext.inc
sys/php-gettext/gettext.php
sys/php-gettext/streams.php
sys/PHPMailer/composer.json
sys/PHPMailer/examples/LGPLv3.txt
sys/PHPMailer/examples/code_generator.phps
sys/PHPMailer/examples/scripts/shCore.js
sys/PHPMailer/extras/EasyPeasyICS.php
sys/PHPMailer/extras/class.html2text.php
sys/PHPMailer/extras/ntlm_sasl_client.php
sys/PHPMailer/test/runfakepopserver.sh
sys/PHPMailer/test/testbootstrap-dist.php

do not contain an 'end of line' character in the last line.
Please, add a linefeed character at the end of the last line.

I stumbled over this, because I tried to append to .htaccess file in vain with:
echo "test" >> "${FILE}"
This resulted in appending the text to the last line, instead of putting it on a new line.

On another note, please, delete the file:
css/foundation-icons/.DS_Store
from distribution. It is a Mac OS X specific file. It stores how to folder content should be displayed in Finder.

Additionally, the file
sys/PHPMailer/docs/faq.html
contains different end of line characters.
Please convert to linefeed end of line characters.

@krugar krugar self-assigned this Apr 14, 2016
@krugar
Copy link
Contributor

krugar commented Apr 15, 2016

this won't make it into 0.4.2 today and i'm semi-convinced it makes all that much of a difference. a number of these files are just standard part of vendor distributions and could actually be removed without loss of functionality for this project. i'll go sift through them on the road to 0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants