Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/remove dummy app #197

Closed
wants to merge 2 commits into from
Closed

Chore/remove dummy app #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92c4925
spec: remove the dummy app
freesteph Jan 6, 2025
439b14b
gem: remove Rails dependencies and don't multi-Ruby the CI
freesteph Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,16 @@ on:
pull_request:
jobs:
rspec:
strategy:
fail-fast: false
matrix:
ruby: ['3.2.6', '3.3.6']
rails: ['8.0.1']
runs-on: ubuntu-latest
name: Testing with Ruby ${{ matrix.ruby }} and Rails ${{ matrix.rails }}
name: RSpec tests
steps:
- uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
ruby-version: 3.2

- name: Install gems
env:
RAILS_VERSION: ${{ matrix.rails }}
run: |
gem install bundler
bundle install --jobs 4 --retry 3
Expand All @@ -42,7 +34,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2.6
ruby-version: 3.2

- name: Install gems
run: |
Expand Down
10 changes: 0 additions & 10 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,6 @@
.bundle/
log/*.log
pkg/
spec/dummy/db/*.sqlite3
spec/dummy/db/*.sqlite3-journal
spec/dummy/db/*.sqlite3-*
spec/dummy/log/*.log
spec/dummy/storage/
spec/dummy/tmp/
spec/dummy/node_modules/
spec/dummy/public/assets/
spec/dummy/config/master.key
spec/dummy/app/assets/builds
coverage
*.gem
.tool-versions
Expand Down
1 change: 0 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
inherit_from: .rubocop_todo.yml

require:
- rubocop-rails
- rubocop-rspec

AllCops:
Expand Down
2 changes: 0 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,4 @@ group 'nanoc' do
gem 'nanoc-live'
end

gem "cssbundling-rails"
gem "rubocop-rails"
gem "rubocop-rspec"
155 changes: 0 additions & 155 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,64 +9,6 @@ PATH
GEM
remote: https://rubygems.org/
specs:
actioncable (8.0.1)
actionpack (= 8.0.1)
activesupport (= 8.0.1)
nio4r (~> 2.0)
websocket-driver (>= 0.6.1)
zeitwerk (~> 2.6)
actionmailbox (8.0.1)
actionpack (= 8.0.1)
activejob (= 8.0.1)
activerecord (= 8.0.1)
activestorage (= 8.0.1)
activesupport (= 8.0.1)
mail (>= 2.8.0)
actionmailer (8.0.1)
actionpack (= 8.0.1)
actionview (= 8.0.1)
activejob (= 8.0.1)
activesupport (= 8.0.1)
mail (>= 2.8.0)
rails-dom-testing (~> 2.2)
actionpack (8.0.1)
actionview (= 8.0.1)
activesupport (= 8.0.1)
nokogiri (>= 1.8.5)
rack (>= 2.2.4)
rack-session (>= 1.0.1)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.2)
rails-html-sanitizer (~> 1.6)
useragent (~> 0.16)
actiontext (8.0.1)
actionpack (= 8.0.1)
activerecord (= 8.0.1)
activestorage (= 8.0.1)
activesupport (= 8.0.1)
globalid (>= 0.6.0)
nokogiri (>= 1.8.5)
actionview (8.0.1)
activesupport (= 8.0.1)
builder (~> 3.1)
erubi (~> 1.11)
rails-dom-testing (~> 2.2)
rails-html-sanitizer (~> 1.6)
activejob (8.0.1)
activesupport (= 8.0.1)
globalid (>= 0.3.6)
activemodel (8.0.1)
activesupport (= 8.0.1)
activerecord (8.0.1)
activemodel (= 8.0.1)
activesupport (= 8.0.1)
timeout (>= 0.4.0)
activestorage (8.0.1)
actionpack (= 8.0.1)
activejob (= 8.0.1)
activerecord (= 8.0.1)
activesupport (= 8.0.1)
marcel (~> 1.0)
activesupport (8.0.1)
base64
benchmark (>= 0.3)
Expand Down Expand Up @@ -94,17 +36,12 @@ GEM
base64 (0.2.0)
benchmark (0.4.0)
bigdecimal (3.1.9)
builder (3.3.0)
byebug (11.1.3)
coderay (1.1.3)
colored (1.2)
concurrent-ruby (1.3.4)
connection_pool (2.4.1)
crass (1.0.6)
cri (2.15.12)
cssbundling-rails (1.4.1)
railties (>= 6.0.0)
date (3.4.1)
ddmetrics (1.1.0)
ddplugin (1.0.3)
deep_merge (1.2.2)
Expand All @@ -114,14 +51,11 @@ GEM
em-websocket (0.5.3)
eventmachine (>= 0.12.9)
http_parser.rb (~> 0)
erubi (1.13.1)
eventmachine (1.2.7)
ffi (1.17.1-arm64-darwin)
ffi (1.17.1-x86_64-darwin)
ffi (1.17.1-x86_64-linux-gnu)
formatador (1.1.0)
globalid (1.2.1)
activesupport (>= 6.1)
guard (2.19.1)
formatador (>= 0.2.4)
listen (>= 2.7, < 4.0)
Expand Down Expand Up @@ -157,10 +91,6 @@ GEM
immutable-ruby (0.2.0)
concurrent-ruby (~> 1.1)
sorted_set (~> 1.0)
io-console (0.8.0)
irb (1.14.3)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
json (2.9.1)
json_schema (0.21.0)
kramdown (2.4.0)
Expand All @@ -170,19 +100,9 @@ GEM
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
logger (1.6.4)
loofah (2.24.0)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
lumberjack (1.2.10)
mail (2.8.1)
mini_mime (>= 0.1.1)
net-imap
net-pop
net-smtp
marcel (1.0.4)
memo_wise (1.10.0)
method_source (1.1.0)
mini_mime (1.1.5)
minitest (5.25.4)
nanoc (4.13.3)
addressable (~> 2.5)
Expand Down Expand Up @@ -224,16 +144,6 @@ GEM
nanoc-cli (~> 4.11, >= 4.11.14)
nanoc-core (~> 4.11, >= 4.11.14)
nenv (0.3.0)
net-imap (0.5.4)
date
net-protocol
net-pop (0.1.2)
net-protocol
net-protocol (0.2.2)
timeout
net-smtp (0.5.0)
net-protocol
nio4r (2.7.4)
nokogiri (1.18.1-arm64-darwin)
racc (~> 1.4)
nokogiri (1.18.1-x86_64-darwin)
Expand All @@ -251,69 +161,23 @@ GEM
racc
pastel (0.8.0)
tty-color (~> 0.5)
propshaft (1.1.0)
actionpack (>= 7.0.0)
activesupport (>= 7.0.0)
rack
railties (>= 7.0.0)
pry (0.14.2)
coderay (~> 1.1)
method_source (~> 1.0)
pry-byebug (3.10.1)
byebug (~> 11.0)
pry (>= 0.13, < 0.15)
psych (5.2.2)
date
stringio
public_suffix (6.0.1)
racc (1.8.1)
rack (3.1.8)
rack-session (2.0.0)
rack (>= 3.0.0)
rack-test (2.2.0)
rack (>= 1.3)
rackup (2.2.1)
rack (>= 3)
rails (8.0.1)
actioncable (= 8.0.1)
actionmailbox (= 8.0.1)
actionmailer (= 8.0.1)
actionpack (= 8.0.1)
actiontext (= 8.0.1)
actionview (= 8.0.1)
activejob (= 8.0.1)
activemodel (= 8.0.1)
activerecord (= 8.0.1)
activestorage (= 8.0.1)
activesupport (= 8.0.1)
bundler (>= 1.15.0)
railties (= 8.0.1)
rails-dom-testing (2.2.0)
activesupport (>= 5.0.0)
minitest
nokogiri (>= 1.6)
rails-html-sanitizer (1.6.2)
loofah (~> 2.21)
nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
railties (8.0.1)
actionpack (= 8.0.1)
activesupport (= 8.0.1)
irb (~> 1.13)
rackup (>= 1.0.0)
rake (>= 12.2)
thor (~> 1.0, >= 1.2.2)
zeitwerk (~> 2.6)
rainbow (3.1.1)
rake (13.2.1)
rb-fsevent (0.11.2)
rb-inotify (0.11.1)
ffi (~> 1.0)
rbtree (0.4.6)
rdoc (6.10.0)
psych (>= 4.0.0)
regexp_parser (2.10.0)
reline (0.6.0)
io-console (~> 0.5)
rexml (3.4.0)
rouge (4.0.1)
rspec (3.13.0)
Expand Down Expand Up @@ -348,11 +212,6 @@ GEM
rubocop (~> 1.41)
rubocop-factory_bot (2.26.1)
rubocop (~> 1.61)
rubocop-rails (2.28.0)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.52.0, < 2.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop-rspec (2.31.0)
rubocop (~> 1.40)
rubocop-capybara (~> 2.17)
Expand Down Expand Up @@ -381,15 +240,10 @@ GEM
sorted_set (1.0.3)
rbtree
set (~> 1.0)
sqlite3 (2.5.0-arm64-darwin)
sqlite3 (2.5.0-x86_64-darwin)
sqlite3 (2.5.0-x86_64-linux-gnu)
stringio (3.1.2)
sysexits (1.2.0)
temple (0.8.2)
thor (1.3.2)
tilt (2.0.11)
timeout (0.4.3)
tty-color (0.6.0)
tty-command (0.10.1)
pastel (~> 0.8)
Expand All @@ -401,15 +255,11 @@ GEM
unicode-emoji (~> 4.0, >= 4.0.4)
unicode-emoji (4.0.4)
uri (1.0.2)
useragent (0.16.11)
view_component (3.21.0)
activesupport (>= 5.2.0, < 8.1)
concurrent-ruby (~> 1.0)
method_source (~> 1.0)
webrick (1.7.0)
websocket-driver (0.7.6)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
yard (0.9.37)
zeitwerk (2.7.1)

Expand All @@ -422,7 +272,6 @@ PLATFORMS
x86_64-linux

DEPENDENCIES
cssbundling-rails
deep_merge
dsfr-view-components!
guard
Expand All @@ -433,19 +282,15 @@ DEPENDENCIES
kramdown (~> 2.4.0)
nanoc
nanoc-live
propshaft
pry-byebug
rails (~> 8)
rouge (~> 4.0.0)
rspec-html-matchers (~> 0.9)
rubocop
rubocop-rails
rubocop-rspec
rubypants (~> 0.7.0)
simplecov (~> 0.20)
slim (~> 4.1.0)
slim_lint (~> 0.22.0)
sqlite3
webrick (~> 1.7.0)
yard

Expand Down
5 changes: 0 additions & 5 deletions dsfr-view-components.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ $LOAD_PATH.push File.expand_path("lib", __dir__)

require "dsfr/components/version"

DEFAULT_RAILS_VERSION = "~> 8"

METADATA = {
"bug_tracker_uri" => "https://github.com/betagouv/dsfr-view-components/issues",
"changelog_uri" => "https://github.com/betagouv/dsfr-view-components/releases",
Expand Down Expand Up @@ -37,13 +35,10 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rspec-html-matchers", "~> 0.9"
spec.add_development_dependency "rubocop"
spec.add_development_dependency("simplecov", "~> 0.20")
spec.add_development_dependency "sqlite3"
spec.add_development_dependency "yard"


# Required for the guide
spec.add_development_dependency("rails", ENV.fetch("RAILS_VERSION", DEFAULT_RAILS_VERSION))
spec.add_development_dependency("propshaft")
spec.add_development_dependency("haml", "~> 6.1.1")
spec.add_development_dependency("haml_lint")
spec.add_development_dependency("htmlbeautifier", "~> 1.4.1")
Expand Down
1 change: 0 additions & 1 deletion spec/dummy/.ruby-version
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions spec/dummy/Procfile.dev
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions spec/dummy/Rakefile
View file
Open in desktop

This file was deleted.

Empty file removed spec/dummy/app/assets/builds/.keep
View file
Open in desktop
Empty file.
Empty file removed spec/dummy/app/assets/images/.keep
View file
Open in desktop
Empty file.
Loading
Loading