Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Action to require passing tests before publishing on tagged releases #300

Open
sahansk2 opened this issue Aug 24, 2020 · 2 comments
Open

Update GitHub Action to require passing tests before publishing on tagged releases #300

sahansk2 opened this issue Aug 24, 2020 · 2 comments
Assignees
@benthayer
Labels
testing Changes to test suites
Milestone
1.x

Comments

@sahansk2
Copy link
Contributor

No description provided.

@benthayer benthayer added the testing Changes to test suites label Aug 25, 2020
@benthayer benthayer added this to the 1.0 milestone Aug 25, 2020
@sahansk2 sahansk2 changed the title Use workflow_run to require passing tests before publishing in GitHub actions Update GitHub Action to require passing tests before publishing on tagged releases Aug 29, 2020
@sahansk2 sahansk2 removed their assignment Aug 29, 2020
@sahansk2
Copy link
Contributor Author

Resolution of #304 is required before work on this can be done. Either repository_dispatch can be used for this, or workflow_run can be used for this (should it support tags. It is a relatively new feature of GitHub actions, so this should be investigated).

I will not be working on this.

@benthayer benthayer assigned sahansk2 and benthayer and unassigned sahansk2 Sep 2, 2020
@benthayer
Copy link
Owner

We can check tests manually before a release. This can be 1.x

@benthayer benthayer modified the milestones: 1.0, 1.x Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benthayer benthayer

Labels
testing Changes to test suites
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
2 participants
@benthayer @sahansk2