Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aw_freeform_table() - more detail if a request fails partway through #71

Open
gilliganondata opened this issue Jan 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@gilliganondata
Copy link
Collaborator

I got the following messages when running an aw_freeform_table() query:

Estimated runtime: 318.4sec./5.31min.
1 of 398 possible data requests complete. Starting the next 397 requests.
Request failed [429]. Retrying in 7 seconds...
A total of 1985 rows have been pulled.

There is no information about the failed request:

At a minimum, something like the following would be reassuring:

Estimated runtime: 318.4sec./5.31min.
1 of 398 possible data requests complete. Starting the next 397 requests.
Request failed [429]. Retrying in 7 seconds...
Retry successful. Continuing with additional requests...
A total of 1985 rows have been pulled.
@gilliganondata gilliganondata added the enhancement New feature or request label Jan 20, 2021
@charlie-gallagher
Copy link
Collaborator

I'm not sure how much control we have over messaging, as the retrying is taken care of by httr::RETRY() (here). But in a recent update we did improve the error messaging significantly to provide better messages when things totally fail.

As long as an error is temporary, it's ok to not know what happened, right? You can mostly assume it was some server error, or temporary internet error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants