Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't Validate TLS #140

Open
dstufft opened this issue Mar 12, 2015 · 4 comments
Open

Doesn't Validate TLS #140

dstufft opened this issue Mar 12, 2015 · 4 comments

Comments

@dstufft
Copy link

dstufft commented Mar 12, 2015

Restkit does not validate TLS which means it's HTTPS handling is broken and insecure.

>>> from restkit import request
>>> r = request("https://tv.eurosport.com/")
>>> r.body_string()
'<HTML><HEAD><TITLE>Error</TITLE></HEAD><BODY>\nAn error occurred while processing your request.<p>\nReference&#32;&#35;102&#46;34e74217&#46;1426170776&#46;e615a32\n</BODY></HTML>\n'
@tdsmith
Copy link

tdsmith commented Aug 4, 2015

This was assigned CVE-2015-2674. http://seclists.org/oss-sec/2015/q1/962

@macropin
Copy link

macropin commented Aug 7, 2015

Since Restkit just wraps the Python ssl socket library, this PEP is relevant https://www.python.org/dev/peps/pep-0476/ (and shows the scope of the issue).

@dstufft if you pass cert_reqs=ssl.CERT_REQUIRED to the request that will force validation. But as far as I can see there is no way to validate the hostname, so the job's only half done. (server_hostname is not a ssl.wrap_socket argument)

@andreasstieger
Copy link

Ping?

@carnil
Copy link

carnil commented Oct 3, 2017

Any news?

@rhertzog rhertzog mentioned this issue Sep 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dstufft @tdsmith @macropin @carnil @andreasstieger