Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density floor setting has inconsistent name in neutral_mixed #267

Open
mikekryjak opened this issue Oct 18, 2024 · 0 comments
Open

Density floor setting has inconsistent name in neutral_mixed #267

mikekryjak opened this issue Oct 18, 2024 · 0 comments
Labels
confusing Something in the code or documentation could be more clear

Comments

@mikekryjak
Copy link
Collaborator

Density floor is named density_floor in most places:

density_floor = options["density_floor"].doc("Minimum density floor").withDefault(1e-5);

But in neutral_mixed it's called nn_floor:

nn_floor = options["nn_floor"]
.doc("A minimum density used when dividing NVn by Nn. "
"Normalised units.")
.withDefault(1e-5);

The name should either be the same, or the neutral_mixed name should be changed to a more distinct one.

@mikekryjak mikekryjak added the confusing Something in the code or documentation could be more clear label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confusing Something in the code or documentation could be more clear
Projects
None yet
Development

No branches or pull requests

1 participant