Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationFile - rename TabWidth to IndentSize #1377

Closed
belav opened this issue Nov 11, 2024 · 2 comments
Closed

ConfigurationFile - rename TabWidth to IndentSize #1377

belav opened this issue Nov 11, 2024 · 2 comments
Milestone
1.0.0

Comments

@belav
Copy link
Owner

belav commented Nov 11, 2024

This will be a breaking change for 1.0.0
@belav belav added this to the 1.0.0 milestone Nov 11, 2024
belav added a commit that referenced this issue Jan 2, 2025
@belav
Changing TabWidth to IndentSize
8effbf2 
closes #1377
belav added a commit that referenced this issue Jan 2, 2025
@belav
Renaming TabWidth to IndentSize
01960f2 
closes #1377
@belav belav mentioned this issue Jan 2, 2025
Merged
@edyoung
Copy link

edyoung commented Jan 3, 2025

I don't personally see any benefit to this change. Either name is pretty clear.

@SigtryggurO
Copy link

SigtryggurO commented Jan 3, 2025 •
edited
Loading

I don't personally see any benefit to this change. Either name is pretty clear.

I assume it's beeing done due to EditorConfig having both tab_width and indent_size where csharpier has only tabWidth which behaves more like EditorConfig indent_size than tab_width

shocklateboy92 pushed a commit that referenced this issue Jan 7, 2025
@belav
Renaming TabWidth to IndentSize (#1425)
c01ebef 
closes #1377
@belav belav closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@edyoung @belav @SigtryggurO