diff --git a/CHANGELOG.md b/CHANGELOG.md index ce8913de3..0992f8ef4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## [next] + +* **MINOR BREAKING** Renamed `NavigationPaneThemeData.standard` to `NavigationPaneThemeData.fromResources`, and removed the `backgroundColor` and `inactiveColor` properties ([#1008](https://github.com/bdlukaa/fluent_ui/issues/1008)) + ## 4.8.4 * feat: Added Croatian localization support ([#1004](https://github.com/bdlukaa/fluent_ui/pull/1004)) diff --git a/example/pubspec.lock b/example/pubspec.lock index 24a052aaa..5bf793765 100644 --- a/example/pubspec.lock +++ b/example/pubspec.lock @@ -143,7 +143,7 @@ packages: path: ".." relative: true source: path - version: "4.8.3" + version: "4.8.4" flutter: dependency: "direct main" description: flutter diff --git a/lib/src/controls/navigation/navigation_view/style.dart b/lib/src/controls/navigation/navigation_view/style.dart index 0f2020d44..5b587a67b 100644 --- a/lib/src/controls/navigation/navigation_view/style.dart +++ b/lib/src/controls/navigation/navigation_view/style.dart @@ -140,14 +140,15 @@ class NavigationPaneThemeData with Diagnosticable { this.paneNavigationButtonIcon, }); - factory NavigationPaneThemeData.standard({ + /// The default navigation pane theme data. + /// + /// This is initialized on [FluentThemeData] with the required properties. + factory NavigationPaneThemeData.fromResources({ required ResourceDictionary resources, required Duration animationDuration, required Curve animationCurve, - required Color backgroundColor, required Color highlightColor, required Typography typography, - required Color inactiveColor, }) { return NavigationPaneThemeData( animationDuration: animationDuration, diff --git a/lib/src/styles/theme.dart b/lib/src/styles/theme.dart index e69dd2af7..beade86bb 100644 --- a/lib/src/styles/theme.dart +++ b/lib/src/styles/theme.dart @@ -303,14 +303,12 @@ class FluentThemeData with Diagnosticable { dialogTheme ??= const ContentDialogThemeData(); tooltipTheme ??= const TooltipThemeData(); dividerTheme ??= const DividerThemeData(); - navigationPaneTheme = NavigationPaneThemeData.standard( + navigationPaneTheme = NavigationPaneThemeData.fromResources( resources: resources, animationCurve: animationCurve, animationDuration: fastAnimationDuration, - backgroundColor: micaBackgroundColor, highlightColor: accentColor.defaultBrushFor(brightness), typography: typography, - inactiveColor: inactiveColor, ).merge(navigationPaneTheme); radioButtonTheme ??= const RadioButtonThemeData(); sliderTheme ??= const SliderThemeData();