Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - deletes #60

Open
bcodell opened this issue Jan 30, 2024 · 0 comments
Open

Feature - deletes #60

bcodell opened this issue Jan 30, 2024 · 0 comments

Comments

@bcodell
Copy link
Owner

bcodell commented Jan 30, 2024

Ideas:

  • <activity>_deletions models that contain two columns: activity_id and deleted_at. users register activities in model config and use a post-hook to apply deletes to registered activities
    • preferred future state
    • need to create post-hook to apply deletes
    • need to recompute activity_occurrence and activity_repeated_at
    • need to update activity_id in activity models to use a non-derived id (breaking change)
  • treat deletes as an activity and filter out records that correspond to a delete in datasets
    • probably the current recommended path
    • a more seamless experience would allow for post-query filtering (akin to supporting filters on different activity conditions)

Open questions:

  • how to handle edge cases where a record is deleted, then un-deleted?
  • should the record be hard deleted from the activity or should a deleted_at field be added?
  • when to recompute activity_occurrence and activity_repeated_at - in deletion model post-hook or activity model post-hook?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant