From 9a91b0197ad3105d6213242e3ac778fdbcba6e89 Mon Sep 17 00:00:00 2001 From: livingrockrises <90545960+livingrockrises@users.noreply.github.com> Date: Fri, 31 May 2024 10:49:55 +0400 Subject: [PATCH] respond to PR comments --- contracts/Nexus.sol | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contracts/Nexus.sol b/contracts/Nexus.sol index 86a6e512..7140185f 100644 --- a/contracts/Nexus.sol +++ b/contracts/Nexus.sol @@ -299,7 +299,9 @@ contract Nexus is INexus, EIP712, BaseAccount, ExecutionHelper, ModuleManager, U } /// Upgrades the contract to a new implementation and calls a function on the new contract. - /// @notice Updates two slots 1. 1967 slot and 2. address() slot in case if it's upgraded earlier from Biconomy V2 account. + /// @notice Updates two slots 1. ERC1967 slot and + /// 2. address() slot in case if it's potentially upgraded earlier from Biconomy V2 account, + /// as Biconomy v2 Account (proxy) reads implementation from the slot that is defined by its address /// @param newImplementation The address of the new contract implementation. /// @param data The calldata to be sent to the new implementation. function upgradeToAndCall(address newImplementation, bytes calldata data) public payable virtual override onlyEntryPointOrSelf {