Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize_variables: Use lookup table of parameters rather than text-matching #86

Open
stephhazlitt opened this issue Jul 5, 2017 · 0 comments

Comments

@stephhazlitt
Copy link
Member

Need to construct a table matching parameters in rems::ems_paramaters to those in wqbc::limits

limit_name ems_parameter ems_param_code
X X Total 123
X X Dissolved 1234

Then standardize_variables should lookup the limits in wqbc::limits using this table, then output from calc_limits should look like this:

Variable Value LimitName UpperLimit LowerLimit
X Total 7 X 11 2
X Dissolved 6 X 11 2
X Suspended 5 X 11 2
X Foo 42 X NA NA

X Foo was not matched in the lookup table

Then calc_limits should have an argument drop saying whether or not to drop the rows where limits were not able to be calculated - either because it wasn't able to be matched in the lookup table, or the limit was dependent on another variable that was not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants