Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc_limits with more informative error messaging #147

Open
sebdalgarno opened this issue Aug 6, 2020 · 2 comments
Open

calc_limits with more informative error messaging #147

sebdalgarno opened this issue Aug 6, 2020 · 2 comments
Assignees

Comments

@sebdalgarno
Copy link
Collaborator

The function does not give any indication to user why limits were not calculated...simply tells them that values were dropped.

Error messaging should be as user-friendly as possible, because they will be captured by the shiny app and displayed verbatim to the user.

@sebdalgarno
Copy link
Collaborator Author

for extra context, the shiny app currently displays a single message if the wqbc::calc_limits returns an error or a data.frame with 0 rows.
"There is insufficient data to calculate the water quality guideline. You could try to get a modelled estimate, change the term, or set the guideline manually."

The team want to know more about what's happening behind the scenes...is there insufficient data for that term argument? is there no limit for that Variable?

@sebdalgarno
Copy link
Collaborator Author

sebdalgarno commented Aug 6, 2020

related to bcgov/shinyrems#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants