From 4b8e94f7268f0a0868d55de04968ec417b475b71 Mon Sep 17 00:00:00 2001 From: CameronEYDS <53542131+cameron-eyds@users.noreply.github.com> Date: Wed, 17 Apr 2024 13:12:27 -0700 Subject: [PATCH] NonRes Exemption Updates + Transfer Feedback Content (#1833) * Mhr Feedback Updates and Bugs * clean up * styling cleanup * FF revert --- ppr-ui/package-lock.json | 4 +- ppr-ui/package.json | 2 +- ppr-ui/src/components/common/Breadcrumb.vue | 8 ++- .../HomeOwners/AddEditHomeOwner.vue | 6 +-- .../HomeOwners/HomeOwnerGroups.vue | 7 ++- .../HomeOwners/HomeOwnersTable.vue | 25 +++++---- .../components/tombstone/TombstoneDynamic.vue | 8 +-- .../composables/exemption/useExemptions.ts | 22 +++++++- .../fees/factories/useFeeSummary.ts | 7 +-- .../mhrRegistration/useHomeOwners.ts | 7 ++- ppr-ui/src/enums/registrationTypes.ts | 2 +- .../exemption-interfaces/ExemptionIF.ts | 5 +- ppr-ui/src/resources/breadcrumbs.ts | 5 ++ .../resources/exemptions/componentContent.ts | 53 ++++++++++++++++++- ppr-ui/src/resources/tableHeaders.ts | 2 +- ppr-ui/src/store/state/state-model.ts | 5 +- .../src/views/exemption/ExemptionDetails.vue | 9 ++-- .../src/views/exemption/ExemptionReview.vue | 18 ++++--- ppr-ui/src/views/exemption/Exemptions.vue | 10 ++-- .../views/mhrInformation/MhrInformation.vue | 13 +++-- 20 files changed, 163 insertions(+), 55 deletions(-) diff --git a/ppr-ui/package-lock.json b/ppr-ui/package-lock.json index ae5c7e1ae..9fc2ecb59 100644 --- a/ppr-ui/package-lock.json +++ b/ppr-ui/package-lock.json @@ -1,12 +1,12 @@ { "name": "ppr-ui", - "version": "3.0.87", + "version": "3.1.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "ppr-ui", - "version": "3.0.87", + "version": "3.1.0", "dependencies": { "@bcrs-shared-components/input-field-date-picker": "^1.0.0", "@lemoncode/fonk": "^1.5.1", diff --git a/ppr-ui/package.json b/ppr-ui/package.json index db1bc90fb..8bb464371 100644 --- a/ppr-ui/package.json +++ b/ppr-ui/package.json @@ -1,6 +1,6 @@ { "name": "ppr-ui", - "version": "3.0.87", + "version": "3.1.0", "private": true, "appName": "Assets UI", "sbcName": "SBC Common Components", diff --git a/ppr-ui/src/components/common/Breadcrumb.vue b/ppr-ui/src/components/common/Breadcrumb.vue index da0d7dfb2..be0e7d0de 100644 --- a/ppr-ui/src/components/common/Breadcrumb.vue +++ b/ppr-ui/src/components/common/Breadcrumb.vue @@ -82,7 +82,7 @@ import { RouteNames } from '@/enums' import { getRoleProductCode } from '@/utils' import { storeToRefs } from 'pinia' import { UnitNotesInfo } from '@/resources/unitNotes' -import { useMhrCorrections } from '@/composables' +import { useExemptions, useMhrCorrections } from '@/composables' export default defineComponent({ name: 'Breadcrumb', @@ -90,6 +90,7 @@ export default defineComponent({ const route = useRoute() const router = useRouter() const { isMhrCorrection } = useMhrCorrections() + const { exemptionLabel } = useExemptions() const { // Getters getRegistrationNumber, @@ -179,7 +180,10 @@ export default defineComponent({ mhrUnitNoteBreadcrumb[3].text = UnitNotesInfo[getMhrUnitNoteType.value].header return mhrUnitNoteBreadcrumb } else if (path?.includes('exemption')) { - return tombstoneBreadcrumbExemption + const exemptionBreadcrumb = [...tombstoneBreadcrumbExemption] + exemptionBreadcrumb[2].text = `MHR Number ${getMhrInformation.value.mhrNumber}` + exemptionBreadcrumb[3].text = exemptionLabel.value + return exemptionBreadcrumb } else { const registrationBreadcrumb = [...tombstoneBreadcrumbRegistration] registrationBreadcrumb[1].text = roleBasedBreadcrumbTitle || registrationBreadcrumb[1].text diff --git a/ppr-ui/src/components/mhrRegistration/HomeOwners/AddEditHomeOwner.vue b/ppr-ui/src/components/mhrRegistration/HomeOwners/AddEditHomeOwner.vue index 26fb94dab..826e183c4 100644 --- a/ppr-ui/src/components/mhrRegistration/HomeOwners/AddEditHomeOwner.vue +++ b/ppr-ui/src/components/mhrRegistration/HomeOwners/AddEditHomeOwner.vue @@ -389,7 +389,7 @@ :ripple="false" @click="remove()" > - {{ isCurrentOwner(owner) ? 'Delete' : 'Remove' }} + {{ isCurrentOwner(owner) ? 'Delete' : 'Remove' }} Owner @@ -587,10 +587,6 @@ export default defineComponent({ TransToExec.prefillOwnerAsExecOrAdmin(defaultHomeOwner) } - if (isFrozenMhr.value && !isFrozenMhrDueToAffidavit.value) { - defaultHomeOwner.partyType = HomeOwnerPartyTypes.OWNER_IND - } - const allFractionalData = (getTransferOrRegistrationHomeOwnerGroups() || [{}]).map(group => { return { groupId: group.groupId || 1, diff --git a/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnerGroups.vue b/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnerGroups.vue index 5eeec3a1a..36725d308 100644 --- a/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnerGroups.vue +++ b/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnerGroups.vue @@ -1,15 +1,14 @@ @@ -129,10 +129,12 @@