Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Requesters to Close Their Active Requests(Public and Private) #4276

Closed
junminahn opened this issue Nov 19, 2024 · 3 comments
Closed
Assignees

Comments

@junminahn
Copy link
Collaborator

junminahn commented Nov 19, 2024

Description:
Currently, there is no straightforward way to cancel active requests. As a result, the product team must rely on admins to manually reject these requests. This issue is especially problematic for public cloud product requests, where admins cannot review the create requests until the eMOU workflows are complete.

Technical Details:

  • Add a new request status, CANCELLED to the database schema.
  • Add document permission on request resources; cancel.
  • Implement logic to remove associated entities for create requests when they are canceled:
    • Billing: Delete incomplete billing records associated with the request's license plate.
    • Tasks: Remove the SIGN_PUBLIC_CLOUD_MOU task linked to the request's EA ID.
  • Add two new event types:
    • CANCEL_PUBLIC_CLOUD_REQUEST
    • CANCEL_PRIVATE_CLOUD_REQUEST
      These events will log cancellation actions.
  • Update the requests panel to include filters for canceled requests.

Definition of Done:

  • The original requester should have access to a "Cancel" button and be able to cancel their requests successfully.
@Kolezhanchik Kolezhanchik changed the title Enable Requesters to Close Their Active Requests Enable Requesters to Close Their Active Create RequestsPublic and Private) Jan 10, 2025
@Kolezhanchik Kolezhanchik changed the title Enable Requesters to Close Their Active Create RequestsPublic and Private) Enable Requesters to Close Their Active Create Requests(Public and Private) Jan 10, 2025
@golebu2020 golebu2020 changed the title Enable Requesters to Close Their Active Create Requests(Public and Private) Enable Requesters to Close Their Active Requests(Public and Private) Jan 13, 2025
@funtigr
Copy link
Collaborator

funtigr commented Jan 16, 2025

  • The requests can be filtered by the Cancelled status.
  • Only the person who actioned the request can Cancel it.
  • If the Approver is mentioned in the product they can either Reject or Cancel the request.
  • When the User has submitted an Edit request and visits it, they can edit the fields but not Submit, only Cancel. For Create request the fields are greyed out. So maybe in the future we would want to grey out the fields for Users for submitted Edit request.
  • The Requests still don't have Billing Codes reflected. I think we can make a separate task for that:

image.png

@golebu2020
Copy link
Collaborator

golebu2020 commented Jan 16, 2025

Hi-Artem-I’ve double-checked your concerns regarding users' fields being editable after submitting an edit request. Upon reviewing, I confirmed that the form in the User Request Tab is not editable, as expected. The fields only become editable in the Admin Decision Tab, which aligns with the intended behaviour.
Screenshot 2025-01-16 at 9.35.18 AM.png
Screenshot 2025-01-16 at 9.35.29 AM.png

@funtigr funtigr closed this as completed Jan 16, 2025
@funtigr
Copy link
Collaborator

funtigr commented Jan 16, 2025

Edit request now has fields greyed out for the User, so that's fixed.
The billing code is now reflected in all types of requests, so that's fixed too.
Closing the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants