From 68d4471cad3f014f0009fa3e459f226edc84263e Mon Sep 17 00:00:00 2001
From: gchauhan-aot <113390759+gchauhan-aot@users.noreply.github.com>
Date: Thu, 10 Oct 2024 13:58:13 -0600
Subject: [PATCH] Resolving Linting Issues For Scheduler (#1633)

---
 .../src/modules/cgi-sftp/cgi-sftp.service.ts  | 35 +++++++++++--------
 .../src/modules/permit/permit.service.ts      |  2 +-
 2 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/scheduler/src/modules/cgi-sftp/cgi-sftp.service.ts b/scheduler/src/modules/cgi-sftp/cgi-sftp.service.ts
index c25d8b1a2..dd8b5ffd5 100644
--- a/scheduler/src/modules/cgi-sftp/cgi-sftp.service.ts
+++ b/scheduler/src/modules/cgi-sftp/cgi-sftp.service.ts
@@ -10,24 +10,29 @@ import * as Client from 'ssh2-sftp-client';
 export class CgiSftpService {
   private readonly logger = new Logger(CgiSftpService.name);
 
-  upload(fileData: Express.Multer.File, fileName: string) {
+  async upload(fileData: Express.Multer.File, fileName: string) {
     const sftp = new Client();
     const connectionInfo: Client.ConnectOptions = getSFTPConnectionInfo();
     const remotePath = process.env.CFS_REMOTE_PATH; //Remote CFS Path
 
-    sftp
-      .connect(connectionInfo)
-      .then(() => {
-        this.logger.log(`writing file ${remotePath}${fileName}`);
-        return sftp.put(fileData.buffer, remotePath + fileName);
-      })
-      .catch((err) => {
-        this.logger.error(err);
-        throw new InternalServerErrorException(err);
-      })
-      .finally(() => {
-        this.logger.log('closing connection');
-        void sftp.end();
-      });
+    try {
+      await sftp.connect(connectionInfo);
+      this.logger.log(`Successfully connected to ${process.env.CFS_SFTP_HOST} via SFTP.`);
+    } catch (error) {
+      this.logger.error('Cannot connect to sftp.');
+      this.logger.error(error);
+    }
+    try {
+      const res = await sftp.put(fileData.buffer, remotePath + fileName);
+      this.logger.log(`Successfully sent file ${fileName} via SFTP.`);
+      return res;
+    } catch (error) {
+      this.logger.error('Failed to send file via SFTP.');
+      this.logger.error(error);
+      throw new InternalServerErrorException('Failed to send file via SFTP.');
+    } finally {
+      this.logger.log('closing connection');
+      void sftp.end();
+    }
   }
 }
diff --git a/scheduler/src/modules/permit/permit.service.ts b/scheduler/src/modules/permit/permit.service.ts
index 89dfb5283..06c45107e 100644
--- a/scheduler/src/modules/permit/permit.service.ts
+++ b/scheduler/src/modules/permit/permit.service.ts
@@ -156,7 +156,7 @@ export class PermitService {
       await lastValueFrom(
         this.httpService
           .post(url, body, reqConfig)
-          .pipe(map((response) => response.data)),
+          .pipe(map((response) => response.data as JSON)),
       );
     } catch (error) {
       this.logger.error(`Error in calling ${url}: ${error}`);