Compatibility issue Celsius, Performance Optimizer

[gaschenk]

There is a compatibility issue when using Celsius and Performance Optimizer with Performance Fish.

Projects

Celsius: https://github.com/GarwelGarwel/Celsius
Related Issues: GarwelGarwel/Celsius#60 GarwelGarwel/Celsius#57
Performance Optimizer: https://github.com/Taranchuk/PerformanceOptimizer

Issue

Celsius reworks the temperature system and updates individual tiles which will with default and recommended settings for PO from Celsius at random cause temperatures to stay locked and potentially only increasing but never decreasing.

There are two options that will cause issues from PO with PF for Celsius:
"Cache WorldGrid:LongLatOf" and "BuildCopyCommandUtility:FindAllowedDesignator"
those two options need likely to be disabled from either side or a solution needs to be found which could make it work.

And there is also one Option from PF that could still cause issues in this case, which would need to be disabled "TryFindBestBetterStoreCellFor"

TryFindBestBetterStoreCellFor

There seem to be both optimizations and threshhold options from PO to be causing issues with TryFindBestBetterStoreCellFor in the case of Celsius. (I do not know which ones)

Incompatibilities:

• Disable plant sway calculations if plant sway is disabled (why how what?)
• Cache StatWorker_MarketValue:CalculableRecipe
• Cache HediffDef:PossibleToDevelopImmunityNaturally

e.g.: only Optimize IdeoBuildingPresenceDemand:BuildingPresent would work

Threshhold options have not been tested so they all have been disabled.

Remarks

Completely removing PO does fix the incompatibility without having to adjust settings but that might not be a desirable solution.

I'll add more depending on the time and findings I have to give further information on which options are interfering.