Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Unsupported language using C# as driver #108

Closed
erizocosmico opened this issue Feb 5, 2019 · 5 comments
Closed

Unsupported language using C# as driver #108

erizocosmico opened this issue Feb 5, 2019 · 5 comments
Assignees
Labels

Comments

@erizocosmico
Copy link

If you set C# as the language, bblfsh says "unsupported language", but if you use csharp it works. The thing is, C# is what enry returns, so it should work on bblfsh as well.

@creachadair creachadair added the bug label Feb 5, 2019
@smola
Copy link
Member

smola commented Feb 13, 2019

Related discussions:
bblfsh/bash-driver#39
bblfsh/documentation#191

@bzz bzz self-assigned this Feb 13, 2019
@bzz
Copy link
Contributor

bzz commented Feb 13, 2019

Until we have a language aliases support bblfsh/bash-driver#39 (comment) on the driver manifest level - we better off keeping our current re-mapping strategy that is already in-place for number of languages.

Right now this is already working for the case of C# + language detection on bblfshd side.
Going to add the same re-mapping for case of user-provided language name.

This way it will also work for any scala-client users as well.

@bzz
Copy link
Contributor

bzz commented Feb 13, 2019

@erizocosmico on

If you set C# as the language, bblfsh says "unsupported language",

If you could be so kind and provide an API call and exact error message on this failure in C# case -
that would help to make sure I did not miss it in the fix.

So far I got

$ bblfsh-cli -l 'C#' ./smth.cs
couldn't parse ./smth.cs: rpc error: code = Unknown desc = unexpected error: runtime failure: missing driver for language "C#"

Would that be the same case you are talking about, right?

@erizocosmico
Copy link
Author

Yes. That's the same issue

@bzz
Copy link
Contributor

bzz commented Feb 14, 2019

Will be part of the next v2.12.0 release scope - let me know if you need it sooner and I'll be happy to 🔪 it asap, otherwise will wait to have more fixes for the release (next week?).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants