From 690531777c06262bb901a26757a02c92a9124bd5 Mon Sep 17 00:00:00 2001
From: hotinglok <hotinglok@gmail.com>
Date: Tue, 22 Oct 2024 15:12:00 +0100
Subject: [PATCH] Make selectors for event triggers more robust

---
 .../pages/ArticlePage/experimentTopStories/helpers.test.tsx  | 4 ++--
 src/app/pages/ArticlePage/experimentTopStories/helpers.tsx   | 5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/app/pages/ArticlePage/experimentTopStories/helpers.test.tsx b/src/app/pages/ArticlePage/experimentTopStories/helpers.test.tsx
index fa375672c23..9570f65ecdd 100644
--- a/src/app/pages/ArticlePage/experimentTopStories/helpers.test.tsx
+++ b/src/app/pages/ArticlePage/experimentTopStories/helpers.test.tsx
@@ -153,14 +153,14 @@ describe('AMP top stories experiment', () => {
             "trackTopStoriesClick": {
               "on": "click",
               "request": "topStoriesClick",
-              "selector": "[data-testid='promo-link']",
+              "selector": "a[aria-labelledby*='top-stories-promo']",
             },
             "trackTopStoriesView": {
               "on": "visible",
               "request": "topStoriesView",
               "visibilitySpec": {
                 "continuousTimeMin": 200,
-                "selector": "[class*='experimentTopStoriesSection']",
+                "selector": "section[aria-labelledby='top-stories-heading']",
                 "totalTimeMin": 500,
                 "visiblePercentageMin": 20,
               },
diff --git a/src/app/pages/ArticlePage/experimentTopStories/helpers.tsx b/src/app/pages/ArticlePage/experimentTopStories/helpers.tsx
index 1d1e0cc3f02..5914e02fdc5 100644
--- a/src/app/pages/ArticlePage/experimentTopStories/helpers.tsx
+++ b/src/app/pages/ArticlePage/experimentTopStories/helpers.tsx
@@ -84,7 +84,7 @@ export const getExperimentAnalyticsConfig = ({
         on: 'visible',
         request: 'topStoriesView',
         visibilitySpec: {
-          selector: `[class*='experimentTopStoriesSection']`,
+          selector: `section[aria-labelledby='top-stories-heading']`,
           visiblePercentageMin: 20,
           totalTimeMin: 500,
           continuousTimeMin: 200,
@@ -93,7 +93,7 @@ export const getExperimentAnalyticsConfig = ({
       trackTopStoriesClick: {
         on: 'click',
         request: 'topStoriesClick',
-        selector: `[data-testid='promo-link']`,
+        selector: `a[aria-labelledby*='top-stories-promo']`,
       },
     },
   };
@@ -193,7 +193,6 @@ export const ExperimentTopStories = ({
     <div
       css={styles.experimentTopStoriesSection}
       data-testid="experiment-top-stories"
-      data-vars-top-stories-position="experiment"
     >
       <TopStoriesSection content={topStoriesContent} />
     </div>