Compilation warnings & other small issues

[bbatsov]

This was reported to me over email:

I am writing to you to tell you of three issues with
solarized-theme that you might want to resolve.

1. When I start Emacs, my initialization uses the ‘desktop’
   restore feature to reload files and buffers that are saved
   at the end of my previous Emacs session. Part of that
   process restarts the solarized-theme (either ‘light’ or
   ‘dark’ depending on my last settings). Each time the
   start-up completes, the mode bar(s) is not highlighted
   correctly and I have to issue a command to solarize (light
   or dark) to restore the correct shade for the mode bar(s).
   After it is reset, it works correctly for the duration of
   the editing session regardless of how many times I switch
   between ‘light’ or ‘dark’.

2. I am using Emacs (version 28) on Gnome. With this
   windowing system, the mode bar has highlighting to give it a
   3-D appearance. When the solarized theme is applied,
   however, the 3-D shading is removed. It does not matter
   whether the ‘light’ or ‘dark’ theme is applied.

3. During installation of the ‘solarized-theme’ package, the
   Emacs Lisp source files are compiled. For several releases,
   the following compilation warning messages are produced
   during compilation. These appear to be harmless, but in
   case you were not aware of them and wanted to resolve them,
   I am including a copy of the compiler warning messages,
   below.

Thank you again for providing solarized-theme for Emacs
users.

solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `orange-1bg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `orange-2bg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `violet-1bg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `violet-1fg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `violet-2bg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `violet-2fg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1bg'
solarized-dark-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1fg'


solarized-dark-theme.el:30:1: Warning: Unused lexical variable `orange-1bg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `orange-2bg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `magenta-1bg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `magenta-1fg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `violet-1bg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `violet-1fg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `violet-2bg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `violet-2fg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `cyan-1bg'
solarized-dark-theme.el:30:1: Warning: Unused lexical variable `cyan-1fg'


solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `orange-1bg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `orange-2bg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `violet-1bg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `violet-1fg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `violet-2bg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `violet-2fg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1bg'
solarized-gruvbox-dark-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1fg'


solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `orange-1bg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `orange-2bg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `violet-1bg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `violet-1fg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `violet-2bg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `violet-2fg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1bg'
solarized-gruvbox-light-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1fg'


solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `orange-1bg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `orange-2bg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `violet-1bg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `violet-1fg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `violet-2bg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `violet-2fg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1bg'
solarized-light-high-contrast-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1fg'


solarized-light-theme.el:30:1: Warning: Unused lexical variable `orange-1bg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `orange-2bg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `magenta-1bg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `magenta-1fg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `violet-1bg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `violet-1fg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `violet-2bg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `violet-2fg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `cyan-1bg'
solarized-light-theme.el:30:1: Warning: Unused lexical variable `cyan-1fg'


solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `orange-1bg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `orange-2bg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `violet-1bg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `violet-1fg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `violet-2bg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `violet-2fg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1bg'
solarized-selenized-black-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1fg'


solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `orange-1bg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `orange-2bg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `violet-1bg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `violet-1fg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `violet-2bg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `violet-2fg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1bg'
solarized-selenized-dark-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1fg'


solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `orange-1bg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `orange-2bg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `violet-1bg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `violet-1fg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `violet-2bg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `violet-2fg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1bg'
solarized-selenized-light-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1fg'


solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `orange-1bg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `orange-2bg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `violet-1bg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `violet-1fg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `violet-2bg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `violet-2fg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1bg'
solarized-selenized-white-theme.el:31:1: Warning: Unused lexical variable
    `cyan-1fg'


solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `orange-1bg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `magenta-1bg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `cyan-1bg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `violet-1bg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `magenta-1fg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `violet-1fg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `cyan-1fg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `orange-2bg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `violet-2bg'
solarized-wombat-dark-theme.el:40:21: Warning: Unused lexical variable
    `violet-2fg'


solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable `orange-1bg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable `orange-2bg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1bg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable
    `magenta-1fg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable `violet-1bg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable `violet-1fg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable `violet-2bg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable `violet-2fg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable `cyan-1bg'
solarized-zenburn-theme.el:31:1: Warning: Unused lexical variable `cyan-1fg'

[thomasf]

Those variables are intentionally left available to be used even if they are not used right now.. It's maybe worth looking into if the warnings can be suppressed somehow.

[bbatsov]

I think it's never a good idea leave warnings around, as those tend to scare the users. You can prefix unused variables with _ and this will suppress the warnings if I remember correctly.