Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_run script doesn't clean hash outputs and doesn't really work on osx vanilla #74

Closed
ittaiz opened this issue Jun 11, 2016 · 2 comments

Comments

@ittaiz
Copy link
Member

ittaiz commented Jun 11, 2016

Hi,
AFAIU OS X has md5 and not md5sum which is why I get ./test_run.sh: line 25: md5sum: command not found when running the script. Don't know if you want this to run on local contributors machines but if it's not important to you maybe it should be noted.
Second problem is that the hash1/hash2 files aren't deleted and aren't ignored.
Sounds to me like they should be deleted if the diff says they're the same. In any case ignoring them could also solve the problem although being a bit more hacky.
One last option is to maybe write them to bazel-out which is currently ignored.

What would you like to do with this issue?

@johnynek
Copy link
Member

As noted in #76 we should run these tests from bazel directly.

If we do that, we can probably use java program to compute the md5, which would be portable.

How does that sound?

@ittaiz
Copy link
Member Author

ittaiz commented Jun 14, 2016

Sounds good. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants