Is the manifest class-path good enough?

[ittaiz]

Hi,
More questions from grokking through the code :)
In def _write_manifest(ctx): you wrote # TODO(bazel-team): I don't think this classpath is what you want.
I tracked it down to this gerrit review where you said that you wrote this since you
... assume the classpath is much larger than that, i.e. your dependencies too. I left this here because it mirrors the super simple existing rule, but I am not sure this works for a larger projects with more dependencies.
Do you still think so?

[johnynek]

Honestly, I just don't know. I think the manifest comes into play when you just run a jar, like java -jar foo.jar and it should do the right thing.

I guess if that is true now for our _deploy.jar, then I guess it is okay. When I wrote that, I didn't see that it was, but I also didn't really care since I didn't use it that way. So, I moved on.

The bazel-team business is just because Google requires some team or user annotation on TODO and this was going into bazel proper at the time.

[ittaiz]

ok. I'll remove the comment and if we'll see problems we'll tackle them

…

On Mon, Feb 27, 2017 at 7:31 PM P. Oscar Boykin ***@***.***> wrote: Honestly, I just don't know. I think the manifest comes into play when you just run a jar, like java -jar foo.jar and it should do the right thing. I guess if that is true now for our _deploy.jar, then I guess it is okay. When I wrote that, I didn't see that it was, but I also didn't really care since I didn't use it that way. So, I moved on. The bazel-team business is just because Google requires some team or user annotation on TODO and this was going into bazel proper at the time. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#154 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF6NCas30Ibe-vwzoC-bzeIKhsJO6ks5rgwhsgaJpZM4MNBqZ> .