Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using unsupported NDK directory #22

Open
keith opened this issue Sep 21, 2022 · 1 comment
Open

Error when using unsupported NDK directory #22

keith opened this issue Sep 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@keith
Copy link
Member

keith commented Sep 21, 2022

Currently if you attempt to use these rules with NDK 21, you get cryptic failures because of broken assumptions. This is expected to fail in general but it would be nicer if the rules reported a clear error for this case instead

@ahumesky
Copy link
Collaborator

the native version of android_ndk_repository reads source.properties:
https://github.com/bazelbuild/bazel/blob/818c5c8693c43fe490c9f6b2c05149eb8f45cf52/src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java#L535

it would probably be pretty straightforward to do something similar in the Starlark version

@ahumesky ahumesky added the enhancement New feature or request label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants