Update Go SDKs #4272
Merged
Update Go SDKs #4272
+149,263
−115,809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
4267-go1.24
branch
6 times, most recently
from
259703c to
49520cd
Compare
|
The remaining tests that fail are crypto tests. I would like to understand why they fail as this seems potentially problematic. @jayconrod Do you happen to have an idea why we are seeing this? |
Update WORKSPACE to 1.24.0 to starting testing and bump the default SDK with Bzlmod to 1.23.6 in line with our policy to use the latest minor version of the oldest maintained release. This requires updating x/tools for WORKSPACE setups.
fmeum
requested review from
tyler-french and
linzhp
and removed request for
tyler-french
linzhp
approved these changes
Feb 17, 2025
|
What were the failures? Not sure if there's an easy way for me to see past BuildKite runs. Without looking in detail, most popular_repos exclusions are due to testdata usage that's difficult to automate. Crypto also tends to use assembly, and we might run into unsupported edge cases there. |
|
Turns out that Go 1.24 disallowed key sizes used by old crypto tests (old as in until a week ago). Fixed by updating x/crypto. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Update WORKSPACE to 1.24.0 to starting testing and bump the default SDK with Bzlmod to 1.23.6 in line with our policy to use the latest minor version of the oldest maintained release.
Which issues(s) does this PR fix?
Fixes #4267
Other notes for review