Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod out of sync with go/private/repositories.bzl #4262

Open
adam-azarchs opened this issue Feb 11, 2025 · 1 comment
Open

go.mod out of sync with go/private/repositories.bzl #4262

adam-azarchs opened this issue Feb 11, 2025 · 1 comment

Comments

@adam-azarchs
Copy link
Contributor

Even before 05ef407, they were already out of sync a bit, but now moreso.
Compare,

rules_go/go.mod

Lines 9 to 25 in 4c47d52

github.com/golang/mock v1.7.0-rc.1
github.com/golang/protobuf v1.5.4
github.com/pmezard/go-difflib v1.0.0
golang.org/x/net v0.33.0
golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d
google.golang.org/genproto v0.0.0-20250115164207-1a7da9e5054f
google.golang.org/grpc v1.67.3
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.5.1
google.golang.org/protobuf v1.36.3
)
require (
golang.org/x/mod v0.17.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250115164207-1a7da9e5054f // indirect
)

vs. for example
"https://github.com/golang/mock/archive/refs/tags/v1.6.0.zip",

"https://github.com/golang/protobuf/archive/refs/tags/v1.5.4.zip",

"https://github.com/googleapis/go-genproto/archive/dc85e6b867a5ebdfeaa293ddb423f00255ec921e.zip",

"https://github.com/golang/sys/archive/refs/tags/v0.20.0.zip",

"https://github.com/protocolbuffers/protobuf-go/archive/refs/tags/v1.33.0.zip",

"https://github.com/grpc/grpc-go/archive/refs/tags/cmd/protoc-gen-go-grpc/v1.3.0.zip",

This may won't cause immediate problems for most people, but it would be nice to keep them in sync until such time as support for WORKSPACE is dropped entirely.

@fmeum
Copy link
Member

fmeum commented Feb 12, 2025

Keeping them in sync is unfortunately an illusion as WORKSPACE uses first-wins semantics and Bzlmod uses MVS. IMO keeping any kind of breaking changes to WORKSPACE to a minimum at this point (including dep version updates) is the best we can do. If any user cares about versions, they need to define their own ones first anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants