Generate facts for targets not in nogo scope #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
4241-transitive-nogo
branch
from
f833241 to
859724f
Compare
|
@fionera Could you test this? |
fmeum
force-pushed
the
4241-transitive-nogo
branch
from
859724f to
d13aeb2
Compare
|
@fmeum Things like deprecations are now being correctly detected. Could you maybe also add a "magic package" alias to run nogo including failures it on all external dependencies? |
Nogo analyzers may need facts from their (transitive) dependencies to operate correctly. We thus need to run nogo on all targets, even those not in scope, but should only register the validation action for the targets that are in scope to have them fail the build on nogo findings.
fmeum
force-pushed
the
4241-transitive-nogo
branch
from
d13aeb2 to
f46f9cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Nogo analyzers may need facts from their (transitive) dependencies to operate correctly. We thus need to run nogo on all targets, even those not in scope, but should only register the validation action for the targets that are in scope to have them fail the build on nogo findings.
Which issues(s) does this PR fix?
Fixes #4241
Other notes for review