Use upstream definitions, fix gopackagesdriver #4185
Conversation
|
It looks like this CI failure: https://buildkite.com/bazel/rules-go-golang/builds/7281#019373f5-722b-4160-8e7b-4cdc32943756 is unrelated to this PR. Going to ignore it for now. |
|
Cc @JamyDev |
|
What else would be needed here to get this landed? |
I'm not sure. At @devzero-inc, we use this patch-set daily, and I know that it definitively works for us, but we also have an entirely cgo-free code base. Earlier, at @fmeum's request, I tried to dig into /why/ specifically CompiledGoFiles isn't getting populated, and experimented with passing |
ellie-idb
force-pushed
the
master
branch
2 times, most recently
from
f8f6dba to
7782270
Compare
|
@JamyDev addressed your comments |
ellie-idb
force-pushed
the
master
branch
5 times, most recently
from
e987ce0 to
b5bd718
Compare
|
@ellie-idb can you update the description to indicate that this is ready for merging in yet, and see if you can fix the build failures? |
|
sure, sorry for the delay |
|
@JamyDev build failures are fixed |
|
Could you rebase onto master? GitHub doesn't let me merge this as is. |
|
rebased |
What type of PR is this?
Bug fix
Feature
What does this PR do? Why is it needed?
With some recent changes made, the gopackagesdriver seems to fail to resolve all standard library imports. This fixes that, as well as migrating the driver to use the upstream definitions as defined here: https://pkg.go.dev/golang.org/x/tools/go/packages#hdr-The_driver_protocol.
Which issues(s) does this PR fix?
Fixes #4184
Fixes #3962