Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: amplitude/skylab-ios-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: bandlab/skylab-ios-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 3 files changed
  • 4 contributors

Commits on Apr 30, 2021

  1. change min deployment target to 12.3 

    I want to integrate Skylab via Carthage. However, Skylab project's min deployment target is iOS 14.2. I think it makes sense to use for Skylab the same min deployment target Amplitude uses, which is iOS 10.0.
    @Lenhador
    Lenhador committed Apr 30, 2021
    Copy the full SHA
    34a105f View commit details

Commits on May 19, 2021

  1. avoid race conditions in storage 

    Our app has faced 58 crashes since we started using Skylab. I see that the access to the map property isn't synchronised.

For example, DefaultSkylabClient.fetchAll works with map on a background thread. At the same time the client may access map from another thread. It leads to a race condition, which mean lead to a crash
    @Lenhador
    Lenhador committed May 19, 2021
    Copy the full SHA
    b23fb84 View commit details

Commits on Sep 21, 2021

  1. cherry pick commit to fix decoding

    Ivan Reinaldo committed Sep 21, 2021
    Copy the full SHA
    37e5970 View commit details

  2. Merge pull request #1 from ivanrein/fix-decoding 

    cherry pick commit to fix decoding
    @Lenhador
    Lenhador authored Sep 21, 2021
    Copy the full SHA
    11df0e7 View commit details

Commits on Sep 22, 2021

  1. fix force unwrapping

    Ivan Reinaldo committed Sep 22, 2021
    Copy the full SHA
    dc825ae View commit details

  2. Merge pull request #2 from ivanrein/fix-force-unwrap 

    fix force unwrapping
    @Lenhador
    Lenhador authored Sep 22, 2021
    Copy the full SHA
    29b3872 View commit details

Commits on Aug 24, 2022

  1. Merge remote-tracking branch 'origin/main' into develop 

    # Conflicts:
#	Skylab.xcodeproj/project.pbxproj
#	Sources/Skylab/UserDefaultsStorage.swift
    @Aranoledur
    Aranoledur committed Aug 24, 2022
    Copy the full SHA
    6da9f0b View commit details

Commits on Aug 26, 2022

  1. Add carthage dep

    @Aranoledur
    Aranoledur committed Aug 26, 2022
    Copy the full SHA
    6b16f08 View commit details

Commits on Mar 8, 2023

  1. Merge pull request #4 from amplitude/main 

    Sync with main
    @Aranoledur
    Aranoledur authored Mar 8, 2023
    Copy the full SHA
    d01e95d View commit details

  2. Merge branch 'main-fork' into develop

    @Aranoledur
    Aranoledur committed Mar 8, 2023
    Copy the full SHA
    08a4a19 View commit details

  3. Merge pull request #3 from bandlab/develop 

    Develop
    @Aranoledur
    Aranoledur authored Mar 8, 2023
    Copy the full SHA
    38db2e9 View commit details
Loading