Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still Maintained? #193

Open
james-ingold opened this issue Feb 8, 2020 · 3 comments
Open

Still Maintained? #193

james-ingold opened this issue Feb 8, 2020 · 3 comments

Comments

@james-ingold
Copy link

Hello,

I saw that greenkeeper was turned off for this repository. Do you use a different scaffolding library for your projects now? Do you need help with maintenance?

Thanks,
James

@balassy
Copy link
Owner

balassy commented Mar 1, 2020

Hello James,

I'm not using a different scaffolding library, in fact I'm not using any library since I don't have an AWS Lambda project at the moment. I turned off Greenkeeper because it often submitted broken PRs that failed on CI and I had to spend tons of time fixing those and waiting for the successful build (mostly on AppVeyor) most of the time with minimal benefits.

After reading your question I was thinking about my options and decided to temporary suspend the maintenance of this project and just now I added a statement about this to the top of the README. Since I'm not working with AWS Lambda now I cannot closely follow the evolution of the platform and validate that this sample is still working and useful. In fact the sample is already a bit outdated since promises are already available for Lambdas for a while and provide a much better coding pattern with async-await than callbacks.

I still believe that this sample has value and I am planning to update it for my next Lambda project.

Thanks for understanding.
György

@pointtoken
Copy link

pointtoken commented Mar 6, 2020

This is a fantastic project and I hope it continues to get love.

Note that to run it on latest AWS, the node version in the serverless.yml needs to be updated to runtime: nodejs10.x.

Also adding async/await is pretty trivial; you can just change gateway methods to look like:
public getCity = async (event: ApiEvent, context: ApiContext): Promise<APIGatewayProxyResult> => {}
and then just return a ResponseBuilder

@james-ingold
Copy link
Author

Thanks for the response @balassy. Definitely understand where you're coming from and appreciate you updating the readme.
@pointtoken Agreed, this is a great project.
I would be open to helping it stay maintained. A couple of things I have on my list => adding async/await, updating the node version, and upgrading tslint to eslint. I'll try to make some prs when I can to help keep it up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants