Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic wraps / unwraps in CLR #1192

Open
jubeira opened this issue Dec 19, 2024 · 1 comment · May be fixed by #1201
Open

Fix automatic wraps / unwraps in CLR #1192

jubeira opened this issue Dec 19, 2024 · 1 comment · May be fixed by #1201
Assignees
@elshan-eth

Comments

@jubeira
Copy link
Contributor

jubeira commented Dec 19, 2024

The CLR was made considering that pools that have buffers would always wrap / unwrap, and that doesn't seem to be the case in practice.

E.g. a pool with sDAI might have a buffer for it, but users will still want to operate with sDAI directly. So we might need to specify when to wrap / unwrap (as with the batch router).
@jubeira
Copy link
Contributor Author

jubeira commented Dec 20, 2024

For non-nested ERC4626 pools, we'll include an array of flags in the same order as the limit amounts: wrap / unwrap if true, use the token in the pool if false. This applies to add (proportional, unbalanced) and remove proportional.

For nested pools we're specifying the tokens, so maybe we can be smart about it and only wrap / unwrap according to the existing inputs. In other words, we'll try to preserve the existing API.

@elshan-eth elshan-eth linked a pull request Dec 27, 2024 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elshan-eth elshan-eth

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jubeira @elshan-eth