From d0551bb4d30715580992a559bc007fa062cd9d2f Mon Sep 17 00:00:00 2001 From: Henry Joerg Date: Fri, 16 Jun 2023 12:05:24 +0000 Subject: [PATCH 1/4] fix type declaration AXATopContentBarProps --- src/components/20-molecules/top-content-bar/index.react.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/20-molecules/top-content-bar/index.react.d.ts b/src/components/20-molecules/top-content-bar/index.react.d.ts index 8fcd470d5c..828442c128 100644 --- a/src/components/20-molecules/top-content-bar/index.react.d.ts +++ b/src/components/20-molecules/top-content-bar/index.react.d.ts @@ -1,6 +1,6 @@ import React from 'react'; -export type Variant = 'warning'; +export type Variant = 'default' | 'warning' | 'success' | 'attention'; export interface AXATopContentBarProps { variant?: Variant; From 8b784255bf01a1262cfc0f3544bd06e8d2192a97 Mon Sep 17 00:00:00 2001 From: Henry Joerg Date: Fri, 16 Jun 2023 12:17:41 +0000 Subject: [PATCH 2/4] onClose added to type declaration of AXATopContentBarProps --- src/components/20-molecules/top-content-bar/index.react.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/20-molecules/top-content-bar/index.react.d.ts b/src/components/20-molecules/top-content-bar/index.react.d.ts index 828442c128..be641b0e44 100644 --- a/src/components/20-molecules/top-content-bar/index.react.d.ts +++ b/src/components/20-molecules/top-content-bar/index.react.d.ts @@ -13,6 +13,7 @@ export interface AXATopContentBarProps { className?: string; children?: React.ReactNode; onClick?: () => void; + onClose?: () => void; } declare function createAXATopContentBar( From 63699470975517ff19c29d1d14019f8a6129af78 Mon Sep 17 00:00:00 2001 From: Henry Joerg Date: Wed, 21 Jun 2023 06:57:09 +0000 Subject: [PATCH 3/4] changelog updated --- src/components/20-molecules/top-content-bar/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/components/20-molecules/top-content-bar/CHANGELOG.md b/src/components/20-molecules/top-content-bar/CHANGELOG.md index 718c892f93..9b8c1fb2fe 100644 --- a/src/components/20-molecules/top-content-bar/CHANGELOG.md +++ b/src/components/20-molecules/top-content-bar/CHANGELOG.md @@ -1,3 +1,7 @@ +## 6.2.1 +- Add missing values for variant type definition. +- Add missing type definition for onClose. + ## 6.2.0 Update package scope, registry and repository URL. #2423 From 48ecee26f419dcc1c879289a395422a006431fd2 Mon Sep 17 00:00:00 2001 From: Henry Joerg Date: Fri, 23 Jun 2023 12:20:31 +0000 Subject: [PATCH 4/4] update documentation --- src/components/20-molecules/top-content-bar/README.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/components/20-molecules/top-content-bar/README.md b/src/components/20-molecules/top-content-bar/README.md index d3903e873e..8ae9844ba9 100644 --- a/src/components/20-molecules/top-content-bar/README.md +++ b/src/components/20-molecules/top-content-bar/README.md @@ -9,9 +9,11 @@ There is also the possibility to add child elements. ### Variant -| Attribute | Details | -| ------------------- | ---------------------------------------------- | -| `variant="warning"` | Show a red top content bar as a warning banner | +| Attribute | Details | +| ------------------- | ---------------------------------------------- | +| `variant="warning"` | Show a red top content bar as a warning banner | +| `variant="success"` | Show a green top content bar as a success banner | +| `variant="attention"` | Show a yellow top content bar as a attention banner | ### ctatext