S3Presigner not considering @ServiceConnection endpoint

[i96751414]

Hi!

Considering the below code:

spring-cloud-aws/spring-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfiguration.java

Lines 105 to 123 in 6151537

	@Bean
	@ConditionalOnMissingBean
	S3Presigner s3Presigner(S3Properties properties, AwsProperties awsProperties,
	AwsCredentialsProvider credentialsProvider, AwsRegionProvider regionProvider,
	ObjectProvider<AwsConnectionDetails> connectionDetails) {
	S3Presigner.Builder builder = S3Presigner.builder().serviceConfiguration(properties.toS3Configuration())
	.credentialsProvider(credentialsProvider).region(AwsClientBuilderConfigurer.resolveRegion(properties,
	connectionDetails.getIfAvailable(), regionProvider));
	if (properties.getEndpoint() != null) {
	builder.endpointOverride(properties.getEndpoint());
	}
	else if (awsProperties.getEndpoint() != null) {
	builder.endpointOverride(awsProperties.getEndpoint());
	}
	Optional.ofNullable(awsProperties.getFipsEnabled()).ifPresent(builder::fipsEnabled);
	Optional.ofNullable(awsProperties.getDualstackEnabled()).ifPresent(builder::dualstackEnabled);
	return builder.build();
	}

It seems S3Presigner is not being built considering the endpoint coming from ObjectProvider<AwsConnectionDetails> connectionDetails. As such, using @ServiceConnection is not possible as the endpoint is not set accordingly.

[maciejwalkowiak]

Thanks for reporting. Would you like to submit a fix?

[i96751414]

Sure, I will do :)