Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional BottleRocket userdata options in AWSNodeTemplate #3166

Closed
xeon22 opened this issue Jan 5, 2023 · 1 comment
Closed

Add additional BottleRocket userdata options in AWSNodeTemplate #3166

xeon22 opened this issue Jan 5, 2023 · 1 comment
Labels
feature New feature or request good-first-issue Good for newcomers

Comments

@xeon22
Copy link

xeon22 commented Jan 5, 2023

Tell us about your request

Add additional bottlerocket userdata options such as:

[settings.dns]
search-list = ["svc.example.com", "example.com"]
[settings.kubernetes]
cluster-domain = "example.com"

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

I have a cluster with a custom cluster-domain. I cannot use karpenter on this cluster to provision nodes as it does not support the additional userdata settings on bottlerocket nodes to define the custom settings.

Are you currently working around this issue?

Will continue to use cluster-autoscaler for that cluster with the custom domain defined.

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@xeon22 xeon22 added the feature New feature or request label Jan 5, 2023
@ellistarn ellistarn added the good-first-issue Good for newcomers label Jan 5, 2023
@lucass4
Copy link
Contributor

lucass4 commented Jan 21, 2023

@ellistarn correct me if I am wrong but I believe this is not needed since bottlerocket accepts the settings:* configuration.
This functionality was implemented in this PR #2081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants